PYL-W0612 · Unused variable found

thoward27 / grade

Active

Unused variable found PYL-W0612

Anti-pattern

Major

4 years ago — 4 years old

Unused variable 'e'

196        results = Run(["cat", "README.md"])()
197        results = AssertStdoutRegex(r"python")(results)
198        self.assertIsInstance(results, CompletedProcess)
199        with self.assertRaises(AssertionError) as e:200            AssertStdoutRegex(r"idontthinkthisshouldbehere")(results)
201
202    def test_regex_stderr(self):

Description

An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.

Bad practice

def update():
    for i in range(10): # Usused variable `i`
        time.sleep(0.01)
        display_result()

Preferred:

def update():
    for _ in range(10):
        time.sleep(0.01)
        display_result()