Re-definition found for builtin function PYL-W0622
Anti-pattern
Minor
4 years ago
—
4 years old
Redefining built-in 'format'
17@click.option(
18 "--output", type=click.File("w"), default="-", help="optional file to write output to"
19)
20def report(format, output):21 """ Report in the default format to stdout. """
22 with open(".grade", "r") as fp:
23 grades = json.load(fp)Redefining built-in 'input'
35 results = self._run(command, **kwargs)
36 return CompletedProcess(results)
37
38 def __init__(self, command, input=None, **kwargs):39 self.command = command
40 self.input = input
41 self.kwargs = kwargsRedefining built-in 'copyright'
19# -- Project information -----------------------------------------------------
20
21project = "Grade"
22copyright = "2019, Tom Howard"23author = "Tom Howard"
24
25# The full version, including alpha/beta/rc tags
Description
Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.
Bad practice
dict = {} # dict is a Python builtin!
for idx, student in enumerate(students):
dict[student] = idx
Preferred:
roll_number = {}
for idx, student in enumerate(students):
roll_number[student] = idx