Exception caught is very general PYL-W0703
Anti-pattern
Major
4 years ago
—
4 years old
Catching too general exception Exception
47 for pipeline in self.pipelines:
48 try:
49 pipeline()
50 except Exception as e:51 logging.exception(e, exc_info=False)
52 else:
53 self._score += self.value[0]Catching too general exception Exception
66 for callback in self.callbacks:
67 try:
68 results = callback(results)
69 except Exception as err: 70 log.debug(err)
71 else:
72 return resultsCatching too general exception Exception
48 def __call__(self, results: CompletedProcess) -> CompletedProcess:
49 try:
50 self.callback(results)
51 except Exception as err: 52 log.debug(err)
53 return results
54 else:
Description
If the except block catches a very general exception, it is likely to catch any unrelated errors too. Try to be more explicit about which exception(s) you're trying to catch.
If you need to catch every other exception, then mark it as intentional by
adding a # skipcq comment.
Bad practice
try:
x = a / b
except Exception:
x = a / (b + 1)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except BaseException:
print('Only use numbers for the input')
Preferred:
try:
x = a / b
except ZeroDivisionError:
x = a / (b + 1)
try:
event_loop.run()
except Exception as exc: # skipcq: PYL-W0703 - Loop can sometimes crash.
sentry.report(exc)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except ValueError:
print('Only use numbers for the input')