Appending to list immediately following its definition PY-W0070
Anti-pattern
Major
a year ago
—
a year old
Appending to list immediately following its definition
19 self.git = self.repo.git
20 self.files = []
21 self.use_staged = use_staged
22 self.flags = [] 23 self.flags.append("-U0")
24 if self.use_staged:
25 self.flags.append("--staged")
Description
Instead of appending items to a list just after creation, it should be refactored to add those items into the list definition itself.
Bad practice
procArgs = []
procArgs.append('terraform-analyzer')
procArgs.append('terraform-docs')
Recommended
procArgs = ['terraform-analyzer', 'terraform-docs']