Inconsistent return statements PYL-R1710
Style
Minor
a year ago
—
a year old
Either all return statements in a function should return an expression, or none of them should.
12 with open(f"tests/fixtures/{filename}", "r") as f:
13 return f.read()
14
15def mock_execute(self, cmd, **kwargs):16 if cmd[1] == "diff":
17 if "--name-only" in cmd:
18 return "poetry.lock\npyproject.toml\ncommitomatic/git.py"
Description
According to PEP8, if any return statement returns an expression, any return statements where no value is returned should explicitly state this as return None, and an explicit return statement should be present at the end of the function (if reachable).
Good:
def foo(x):
if x >= 0:
return math.sqrt(x)
else:
return None
def bar(x):
if x < 0:
return None
return math.sqrt(x)
Bad:
def foo(x):
if x >= 0:
return math.sqrt(x)
def bar(x):
if x < 0:
return
return math.sqrt(x)