Useless inheritance from
object PYL-R0205
Anti-pattern
Major
4 years ago
—
4 years old
Class 'Connection' inherits from object, can be safely removed from bases in python3
97 return urls
98
99
100class Connection(object):101 """A class for sending/receiving samples via ZMQ sockets."""
102
103 def __init__(self, urls=None, noexpand=False, keep_meta=True, **kw):Class 'MultiWriter' inherits from object, can be safely removed from bases in python3
179 self.close()
180
181
182class MultiWriter(object):183 """A class for sending/receiving samples via ZMQ sockets."""
184
185 def __init__(self, urls=None, noexpand=False, keep_meta=True, linger=-1, output_mode="random", **kw):Class 'TarWriter1' inherits from object, can be safely removed from bases in python3
14__all__ = "TarWriter1 TarWriter".split()
15
16
17class TarWriter1(object): 18 """ """
19
20 def __init__(self, fileobj, keep_meta=False, user="bigdata", group="bigdata", mode=0o0444, compress=None, encoder=None, output_mode=None):Class 'TarIterator1' inherits from object, can be safely removed from bases in python3
106 return samples
107
108
109class TarIterator1(object):110 """Iterate of tar files consisting of samples.
111
112 :param url: source URLClass 'ChDir' inherits from object, can be safely removed from bases in python3
31 stream.write(data)
32
33
34class ChDir(object):35 def __init__(self, path):
36 self.old_dir = os.getcwd()
37 self.new_dir = path
Description
The class is inheriting from object, which is implicit under Python 3 , hence can be safely removed from bases.
Not preferred:
class Foo(object):
"""Foo bar baz"""
Preferred:
class Foo:
"""Foo bar baz"""