Unused variable found PYL-W0612
Anti-pattern
Major
4 years ago
—
4 years old
Unused variable 'ext'
89 "Generate docs."
90 document = ""
91 for fname in glob.glob("tarproclib/*.py"):
92 module, ext = os.path.splitext(fname) 93 module = re.sub("/", ".", module)
94 with os.popen(f"{ACTIVATE}{PYTHON3} -m pydoc {module}") as stream:
95 text = stream.read()Unused variable 'transport'
40 :param linger: linger flag
41 """
42 addr = urlparse(url)
43 scheme, transport = (addr.scheme.split("+", 2) + ["tcp"])[:2] 44 kind, bind = schemes[scheme]
45 logging.info("kind %s bind %s", kind, bind)
46 socket = context.socket(kind)Unused variable 'transport'
119 if not isinstance(url, (str, list)):
120 return TarWriter1(url, **kw)
121 addr = urlparse(url if isinstance(url, str) else url[0])
122 scheme, transport = (addr.scheme.split("+", 2) + ["tcp"])[:2]123 if scheme in zmq_schemes:
124 from . import zcom
125 return zcom.MultiWriter(url, **kw)Unused variable 'transport'
163 if not isinstance(url, (str, list)):
164 return TarIterator1(url, **kw)
165 addr = urlparse(url if isinstance(url, str) else url[0])
166 scheme, transport = (addr.scheme.split("+", 2) + ["tcp"])[:2]167 if scheme in zmq_schemes:
168 from . import zcom
169 return zcom.Connection(url, **kw)
Description
An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.
Bad practice
def update():
for i in range(10): # Usused variable `i`
time.sleep(0.01)
display_result()
Preferred:
def update():
for _ in range(10):
time.sleep(0.01)
display_result()