Function contains unused argument PYL-W0613
Anti-pattern
Major
4 years ago
—
4 years old
Unused argument 'tmpdir'
74 run(f"{PY}tar2json -k txt < {tmpdir}/tar2.tar", 'txt: a')
75 # TODO check for actually sorted
76
77def test_tarsplit(tmpdir):78 run(f"{PY}tarsplit --help", "Split a tar")
Unused argument 'tmpdir'
35 run(f"{PY}lines2tar < {tmpdir}/lines.txt | {PY}tar2json -k txt", "txt: a")
36
37
38def test_tarcats(tmpdir):39 run(f"{PY}tarcats --help", "Concatenate")
40
41Unused argument 'tmpdir'
46 run(f"{PY}tar2json -k txt < {tmpdir}/tar12.tar", "txt: a", "txt: e")
47
48
49def test_tarproc(tmpdir):50 run(f"{PY}tarproc --help", "Each sample is extracted")
51
52Unused argument 'tmpdir'
57 run(f"{PY}tar2json -k x.txt < {tmpdir}/tar2.tar", 'x.txt: a')
58
59
60def test_tarshow(tmpdir):61 run(f"{PY}tarshow --help", "Show data inside")
62
63Unused argument 'kw'
14PY = f"{PYTHON3} {PREFIX}/"
15
16
17def run(script, *args, **kw):18 result = subprocess.check_output(
19 ["/bin/bash", "-c", script], stderr=subprocess.STDOUT
20 ).decode("utf-8")
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42