PYL-W0622 · Re-definition found for builtin function

tmbdev / tarproc

Active

Re-definition found for builtin function PYL-W0622

Anti-pattern

Minor

4 years ago — 4 years old

Redefining built-in 'dir'

180
181
182def docker_build(c, instructions, files=[], nocache=False):
183    with tempfile.TemporaryDirectory() as dir:184        with open(dir + "/Dockerfile", "w") as stream:
185            stream.write(instructions)
186        for fname in files:

Description

Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.

Bad practice

dict = {}  # dict is a Python builtin!
for idx, student in enumerate(students):
    dict[student] = idx

Preferred:

roll_number = {}
for idx, student in enumerate(students):
    roll_number[student] = idx