File .deepsource.toml not found in the default branch of the repository root. Please refer to the docs.
Found unnecessary boolean casts JS-0012
Bug risk
Minor
a year ago
—
a year old
Found unneccessary boolean cast
111 {metric.metric_type === "stateful" && (
112 <p>
113 <b className="mr-2">Event Type:</b>
114 {!!metric.event_type ? <Tag>{metric.event_type}</Tag> : "N/A"}115 </p>
116 )}
117 </div>Found unneccessary boolean cast
101 {metric.metric_type === "rate" && (
102 <p>
103 <b className="mr-2">Aggregation Type:</b>
104 {!!metric.billable_aggregation_type ? (105 <Tag>{metric.billable_aggregation_type}</Tag>106 ) : (107 "N/A"108 )}109 </p>
110 )}
111 {metric.metric_type === "stateful" && (Found unneccessary boolean cast
64 return (
65 <div>
66 <h2 className="mb-2 pb-4 pt-4 font-bold text-main">Credit Balance</h2>
67 {!!balanceAdjustments?.length ? (68 <Table69 columns={columns}70 dataSource={balanceAdjustments}71 pagination={{ pageSize: 10 }}72 />73 ) : (74 <p>No Credit Items Found</p>75 )}76 </div>
77 );
78};
Description
In contexts such as an if statement's test where the result of the expression will already be coerced to a Boolean, casting to a Boolean via double negation (!!) or a Boolean call is unnecessary.
Bad Practice
const cond = !!!isPresent;
const cond2 = Boolean(!!isPresent);
if (!!cond) {
// ...
}
if (Boolean(cond2)) {
// ...
}
while (!!cond3) {
// ...
}
do {
// ...
} while (Boolean(cond));
for (; !!cond; ) {
// ...
}
Recommended
const cond = !!isPresent;
const cond2 = Boolean(isPresent);
function checkCond() {
return !!isPresent;
}
const cond3 = !!(isPresent ? flag : flag2);