File .deepsource.toml not found in the default branch of the repository root. Please refer to the docs.
Unnecessary literal PTC-W0018
Anti-pattern
Minor
a year ago
—
a year old
Unnecessary list literal - rewrite as set literal syntax
154 )
155 assert response.status_code == status.HTTP_201_CREATED
156 assert PlanVersion.objects.all().count() == 2
157 assert set(PlanVersion.objects.values_list("version", flat=True)) == set([1, 2])158 assert set(PlanVersion.objects.values_list("status", flat=True)) == set(
159 [PLAN_VERSION_STATUS.ACTIVE, PLAN_VERSION_STATUS.INACTIVE]
160 )Unnecessary list literal - rewrite as set literal syntax
155 assert response.status_code == status.HTTP_201_CREATED
156 assert PlanVersion.objects.all().count() == 2
157 assert set(PlanVersion.objects.values_list("version", flat=True)) == set([1, 2])
158 assert set(PlanVersion.objects.values_list("status", flat=True)) == set(159 [PLAN_VERSION_STATUS.ACTIVE, PLAN_VERSION_STATUS.INACTIVE]
160 )
161 assert response.data["created_by"] == setup_dict["user"].usernameUnnecessary list literal - rewrite as set literal syntax
173 data=json.dumps(setup_dict["plan_payload"], cls=DjangoJSONEncoder),
174 content_type="application/json",
175 )
176 assert set(PlanVersion.objects.values_list("version", "status")) == set(177 [(1, PLAN_VERSION_STATUS.ACTIVE)]
178 )
179 plan = Plan.objects.get(plan_id=response.data["plan_id"])Unnecessary list literal - rewrite as set literal syntax
189
190 assert response.status_code == status.HTTP_201_CREATED
191 assert PlanVersion.objects.all().count() == 2
192 assert set(PlanVersion.objects.values_list("version", "status")) == set(193 [(1, PLAN_VERSION_STATUS.ACTIVE), (2, PLAN_VERSION_STATUS.INACTIVE)]
194 )
195 assert response.data["created_by"] == setup_dict["user"].usernameUnnecessary list literal - rewrite as set literal syntax
229
230 assert response.status_code == status.HTTP_201_CREATED
231 assert PlanVersion.objects.all().count() == 2
232 assert set(PlanVersion.objects.values_list("version", flat=True)) == set([1, 2])233 assert set(PlanVersion.objects.values_list("status", flat=True)) == set(
234 [PLAN_VERSION_STATUS.ACTIVE, PLAN_VERSION_STATUS.GRANDFATHERED]
235 )
Description
It is unnecessary to use a list or tuple literal within a call to tuple, list, set, or dict since there is a literal syntax for these types.