Unused variable found PYL-W0612
Anti-pattern
Major
a year ago
—
a year old
Unused variable 'required_source'
36
37 def get(self, request, source_id):
38 try:
39 required_source = Source.objects.get(pk=source_id)40 except Source.DoesNotExist:
41 return Response(status=status.HTTP_400_BAD_REQUEST)
42 all_events = Events.objects.filter(source=source_id)
Description
An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.
Bad practice
def update():
for i in range(10): # Usused variable `i`
time.sleep(0.01)
display_result()
Preferred:
def update():
for _ in range(10):
time.sleep(0.01)
display_result()