Function contains unused argument PYL-W0613
Anti-pattern
Major
a year ago
—
a year old
Unused argument 'project_id'
90 except Source.DoesNotExist:
91 raise Http404
92
93 def get(self, request, project_id, pk): 94 serialized_source = SourceSerializer(self.get_object(pk=pk))
95 return Response(serialized_source.data)
96Unused argument 'project_id'
103 return Response(serialized_source.data, status=status.HTTP_202_ACCEPTED)
104 return Response(serialized_source.errors, status=status.HTTP_400_BAD_REQUEST)
105
106 def delete(self, request, project_id, pk):107 try:
108 required_source = Source.objects.get(pk=pk)
109 except Source.DoesNotExist:Unused argument 'source_uuid'
57 serialized_event = EventSerializer(self.get_object(pk=pk))
58 return Response(serialized_event.data)
59
60 def delete(self, request, source_uuid, pk):61 try:
62 required_event = Events.objects.get(pk=pk)
63 except Events.DoesNotExist:Unused argument 'source_uuid'
53 except Events.DoesNotExist:
54 raise Http404
55
56 def get(self, request, source_uuid, pk):57 serialized_event = EventSerializer(self.get_object(pk=pk))
58 return Response(serialized_event.data)
59
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42