this value of ctx is never used
55}
56
57func (s *server) IndexDetail(ctx context.Context, _ *payload.Empty) (res *payload.Info_Index_Detail, err error) {
58 ctx, span := trace.StartSpan(ctx, "vald/manager-index.IndexDetail")59 defer func() {
60 if span != nil {
61 span.End()this value of ctx is never used
41}
42
43func (s *server) IndexInfo(ctx context.Context, _ *payload.Empty) (res *payload.Info_Index_Count, err error) {
44 ctx, span := trace.StartSpan(ctx, "vald/manager-index.IndexInfo")45 defer func() {
46 if span != nil {
47 span.End()
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}