VET-V0008 @ bf5713f • vdaas / vald

Run summary

a year ago

bf5713f..bf5713f

5 mins 20 s

Lock erroneously passed by value VET-V0008

Bug risk

Critical

150 occurrences in this check

range var tc copies lock: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.test contains github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.fields contains github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 648		*/
 649	}
 650
 651	for _, tc := range tests { 652		test := tc
 653		t.Run(test.name, func(tt *testing.T) {
 654			tt.Parallel()

assignment copies lock value to test: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.test contains github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.fields contains github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 539	}
 540
 541	for _, tc := range tests {
 542		test := tc 543		t.Run(test.name, func(tt *testing.T) {
 544			tt.Parallel()
 545			defer goleak.VerifyNone(tt, goleak.IgnoreCurrent())

pkg/agent/core/ngt/service/vqueue/queue_test.go

 538		*/
 539	}
 540
 541	for _, tc := range tests { 542		test := tc
 543		t.Run(test.name, func(tt *testing.T) {
 544			tt.Parallel()

literal copies lock value from test.fields.dl: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 445			}
 446			v := &vqueue{
 447				il: test.fields.il,
 448				dl: test.fields.dl, 449				ic: test.fields.ic,
 450				dc: test.fields.dc,
 451			}

pkg/agent/core/ngt/service/vqueue/queue_test.go

 201		*/
 202	}
 203
 204	for _, tc := range tests { 205		test := tc
 206		t.Run(test.name, func(tt *testing.T) {
 207			tt.Parallel()

pkg/agent/core/ngt/service/vqueue/queue_test.go

 870		*/
 871	}
 872
 873	for _, tc := range tests { 874		test := tc
 875		t.Run(test.name, func(tt *testing.T) {
 876			tt.Parallel()

literal copies lock value from test.fields.il: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 217				checkFunc = defaultCheckFunc
 218			}
 219			v := &vqueue{
 220				il: test.fields.il, 221				dl: test.fields.dl,
 222				ic: test.fields.ic,
 223				dc: test.fields.dc,

literal copies lock value from test.fields.dl: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 218			}
 219			v := &vqueue{
 220				il: test.fields.il,
 221				dl: test.fields.dl, 222				ic: test.fields.ic,
 223				dc: test.fields.dc,
 224			}

pkg/agent/core/ngt/service/vqueue/queue_test.go

 314		*/
 315	}
 316
 317	for _, tc := range tests { 318		test := tc
 319		t.Run(test.name, func(tt *testing.T) {
 320			tt.Parallel()

pkg/agent/core/ngt/service/vqueue/queue_test.go

 315	}
 316
 317	for _, tc := range tests {
 318		test := tc 319		t.Run(test.name, func(tt *testing.T) {
 320			tt.Parallel()
 321			defer goleak.VerifyNone(tt, goleak.IgnoreCurrent())

literal copies lock value from test.fields.il: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 330				checkFunc = defaultCheckFunc
 331			}
 332			v := &vqueue{
 333				il: test.fields.il, 334				dl: test.fields.dl,
 335				ic: test.fields.ic,
 336				dc: test.fields.dc,

literal copies lock value from test.fields.dl: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 331			}
 332			v := &vqueue{
 333				il: test.fields.il,
 334				dl: test.fields.dl, 335				ic: test.fields.ic,
 336				dc: test.fields.dc,
 337			}

pkg/agent/core/ngt/service/vqueue/queue_test.go

 428		*/
 429	}
 430
 431	for _, tc := range tests { 432		test := tc
 433		t.Run(test.name, func(tt *testing.T) {
 434			tt.Parallel()

pkg/agent/core/ngt/service/vqueue/queue_test.go

 429	}
 430
 431	for _, tc := range tests {
 432		test := tc 433		t.Run(test.name, func(tt *testing.T) {
 434			tt.Parallel()
 435			defer goleak.VerifyNone(tt, goleak.IgnoreCurrent())

literal copies lock value from test.fields.il: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 444				checkFunc = defaultCheckFunc
 445			}
 446			v := &vqueue{
 447				il: test.fields.il, 448				dl: test.fields.dl,
 449				ic: test.fields.ic,
 450				dc: test.fields.dc,

literal copies lock value from test.fields.dl: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 555			}
 556			v := &vqueue{
 557				il: test.fields.il,
 558				dl: test.fields.dl, 559				ic: test.fields.ic,
 560				dc: test.fields.dc,
 561			}

pkg/agent/core/ngt/service/vqueue/queue_test.go

 649	}
 650
 651	for _, tc := range tests {
 652		test := tc 653		t.Run(test.name, func(tt *testing.T) {
 654			tt.Parallel()
 655			defer goleak.VerifyNone(tt, goleak.IgnoreCurrent())

literal copies lock value from test.fields.il: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 664				checkFunc = defaultCheckFunc
 665			}
 666			v := &vqueue{
 667				il: test.fields.il, 668				dl: test.fields.dl,
 669				ic: test.fields.ic,
 670				dc: test.fields.dc,

literal copies lock value from test.fields.dl: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 665			}
 666			v := &vqueue{
 667				il: test.fields.il,
 668				dl: test.fields.dl, 669				ic: test.fields.ic,
 670				dc: test.fields.dc,
 671			}

pkg/agent/core/ngt/service/vqueue/queue_test.go

 760	}
 761
 762	for _, tc := range tests {
 763		test := tc 764		t.Run(test.name, func(tt *testing.T) {
 765			tt.Parallel()
 766			defer goleak.VerifyNone(tt, goleak.IgnoreCurrent())

literal copies lock value from test.fields.il: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 775				checkFunc = defaultCheckFunc
 776			}
 777			v := &vqueue{
 778				il: test.fields.il, 779				dl: test.fields.dl,
 780				ic: test.fields.ic,
 781				dc: test.fields.dc,

literal copies lock value from test.fields.dl: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 776			}
 777			v := &vqueue{
 778				il: test.fields.il,
 779				dl: test.fields.dl, 780				ic: test.fields.ic,
 781				dc: test.fields.dc,
 782			}

pkg/agent/core/ngt/service/vqueue/queue_test.go

 871	}
 872
 873	for _, tc := range tests {
 874		test := tc 875		t.Run(test.name, func(tt *testing.T) {
 876			tt.Parallel()
 877			defer goleak.VerifyNone(tt, goleak.IgnoreCurrent())

literal copies lock value from test.fields.il: github.com/vdaas/vald/pkg/agent/core/ngt/service/vqueue.indexMap contains sync.Mutex

pkg/agent/core/ngt/service/vqueue/queue_test.go

 886				checkFunc = defaultCheckFunc
 887			}
 888			v := &vqueue{
 889				il: test.fields.il, 890				dl: test.fields.dl,
 891				ic: test.fields.ic,
 892				dc: test.fields.dc,

pkg/agent/core/ngt/service/vqueue/queue_test.go

 202	}
 203
 204	for _, tc := range tests {
 205		test := tc 206		t.Run(test.name, func(tt *testing.T) {
 207			tt.Parallel()
 208			defer goleak.VerifyNone(tt, goleak.IgnoreCurrent())

Description

Inadvertently copying a value containing a lock, such as sync.Mutex or sync.WaitGroup, may cause both copies to malfunction. Generally such values should be referred to through a pointer.

For example,

var x *sync.Mutex
p := x
var y sync.Mutex
p = &y
*p = *x

is not recommended because it copies the lock value.