Expected a default case
23}
24
25function keyPush(event) {
26 switch (event.keyCode) { 27 case 37: 28 if (speedY !== 0 || wormIsNotMoving()) { 29 speedX = -1; 30 speedY = 0; 31 } 32 break; 33 case 38: 34 if (speedX !== 0 || wormIsNotMoving()) { 35 speedX = 0; 36 speedY = -1; 37 } 38 break; 39 case 39: 40 if (speedY !== 0 || wormIsNotMoving()) { 41 speedX = 1; 42 speedY = 0; 43 } 44 break; 45 case 40: 46 if (speedX !== 0 || wormIsNotMoving()) { 47 speedX = 0; 48 speedY = 1; 49 } 50 break; 51 } 52}
53
54function game() {
Description
Some code conventions require that all switch statements have a default case, even if the default case is empty. The idea is to always explicitly state what the default behavior should be so that it's clear that the developer didn't forget to handle the default fallback case.
Bad Practice
switch (a) {
case 1:
/* code */
break;
}
Recommended
switch (a) {
case 1:
/* code */
break;
default:
/* code */
break;
}
switch (a) {
case 1:
/* code */
break;
// no default
}
switch (a) {
case 1:
/* code */
break;
// No Default
}