Detected empty functions JS-0321
Anti-pattern
Minor
23 days ago
—
a year old
Unexpected empty method 'onSuccess'
39 })
40 const variants = useCustomVariant()
41 const theme = useMantineTheme()
42 const pwResetHandler = api.user.forgotPassword.useMutation({ onSuccess: () => {} }) 43 const { animateCSS, fireEvent } = useShake({ variant: 1 })
44 const [opened, handler] = useDisclosure(false)
45 const { isMobile } = useScreenSize()Unexpected empty arrow function
39 .command(
40 'down',
41 'Stop docker containers',
42 () => {},43 async () => {
44 try {
45 await compose.ps({ config: dockerComposeFile })Unexpected empty arrow function
23 .command(
24 'up',
25 'Start docker containers',
26 () => {},27 async () => {
28 if (process.env.DATABASE_URL && postgresLocalUrlRegex.test(process.env.DATABASE_URL)) {
29 console.log("Starting docker...")
Description
Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.
Bad Practice
getUser('SwaGaLisTiQuE', () => {})
Recommended
getUser('SwaGaLisTiQuE', () => {
// empty because <reason>
})