weareinreach / InReach

Bad function overloading JS-0388
Anti-pattern
Minor
4 occurrences in this check
These overloads can be combined into one signature taking Array<AddFileStringParams> | Array<AddDatabaseStringParams>
157}
158interface AddMultipleKeys {
159	(params: Array<AddFileStringParams>): Promise<Array<ResponseObject<SourceStringsModel.String>>>
160	(params: Array<AddDatabaseStringParams>): Promise<Array<ResponseObject<SourceStringsModel.String>>>161}
162
163interface AddDatabaseStringParams {
These overloads can be combined into one signature taking AddDatabaseStringParams | AddFileStringParams
153
154interface AddSingleKey {
155	(params: AddDatabaseStringParams): Promise<SourceStringsModel.String>
156	(params: AddFileStringParams): Promise<SourceStringsModel.String>157}
158interface AddMultipleKeys {
159	(params: Array<AddFileStringParams>): Promise<Array<ResponseObject<SourceStringsModel.String>>>
These overloads can be combined into one signature taking Array<UpdateStringByKey> | Array<UpdateStringById>
148}
149interface UpdateMultipleStrings {
150	(updates: Array<UpdateStringByKey>): Promise<Array<ResponseObject<SourceStringsModel.String>>>
151	(updates: Array<UpdateStringById>): Promise<Array<ResponseObject<SourceStringsModel.String>>>152}
153
154interface AddSingleKey {
These overloads can be combined into one signature taking UpdateStringByKey | UpdateStringById
144
145interface UpdateSingleString {
146	({ key, updatedString, isDatabaseString }: UpdateStringByKey): Promise<SourceStringsModel.String>
147	({ crowdinId, updatedString }: UpdateStringById): Promise<SourceStringsModel.String>148}
149interface UpdateMultipleStrings {
150	(updates: Array<UpdateStringByKey>): Promise<Array<ResponseObject<SourceStringsModel.String>>>