Found unneeded field pattern RS-C1010
Anti-pattern
Minor
a year ago
—
a year old
Following struct field
do_ip was matched with a wildcard, consider using .. instead424 }
425 }
426 }
427 InstructionKind::Keyword(Keyword::While { self_ip, do_ip: _ }) => {428 *self_ip = ip;
429 jump_stack.push(("while", Some(self_ip), None, ip, None));
430 }
Description
This checker looks for struct field patterns bound to wildcards. Prefer ..
instead, as it is shorter and directs focus towards fields that are actually bound.
Replace occurrences of wildcard field patterns with the rest operator, ...
Bad practice
match s {
S { a: 0, b: _, c: _ } => (),
S { a: _, b: _, c: _, .. } => (),
}
Recommended
match s {
S { a: 0, .. } => (),
S { .. } => (),
}