RS-P1100 · Found single-character string literal pattern

willothy / worth

Active

Found single-character string literal pattern RS-P1100

Performance

Major

a year ago — a year old

Using single-character literal as pattern in replacen, use a char instead

218            if err {
219                line.push_str(&inst.postfix.replace("\n", ""));
220            } else {
221                line.push_str(&inst.postfix.replacen("\n", "", 1));222            }
223        }
224        lines.push(line.trim_end_matches(' ').to_owned());

Using single-character literal as pattern in replacen, use a char instead

src/error.rs

201            if err {
202                line.push_str(&inst.prefix.replace("\n", ""));
203            } else {
204                line.push_str(&inst.prefix.replacen("\n", "", 1));205            }
206            if line.trim_matches('\n').len() == 0
207                && !matches!(

Using single-character literal as pattern in replace, use a char instead

src/error.rs

216            line.push_str(&inst.value);
217            line.push_str(&inst.postcolor);
218            if err {
219                line.push_str(&inst.postfix.replace("\n", ""));220            } else {
221                line.push_str(&inst.postfix.replacen("\n", "", 1));
222            }

Using single-character literal as pattern in replace, use a char instead

src/error.rs

199                }
200            }
201            if err {
202                line.push_str(&inst.prefix.replace("\n", ""));203            } else {
204                line.push_str(&inst.prefix.replacen("\n", "", 1));
205            }

Using single-character literal as pattern in replace, use a char instead

src/codegen/compile.rs

297    ld_cmd.args(&[&obj_out_path_str, "-o", &exe_out_path_str]);
298    log::log(
299        LogLevel::Cmd,
300        format!("{:?}", ld_cmd).replace("\"", ""),301        opt.debug,
302    );
303    let ld = ld_cmd

Description

Certain str functions, such as .split() and .find() work on patterns that accept both string literals as well as characters. When using such functions, prefer chars over single-character string literals as they are more performant.

Replace the single-character string literal with a char.

Bad practice

let x = "hello, world";
x.find("o"); // single-character str

willothy / worth

Bad practice

Recommended