Found unnecessary boolean comparison RS-W1001
Anti-pattern
Minor
a year ago
—
a year old
Found unnecessary boolean comparison
21 program.name
22 ))?;
23 let mut depth = 0;
24 while expand_macros(&mut program).context(format!( 25 "Failed to process macros for {}.porth", 26 program.name 27 ))? == true 28 {
29 if depth >= 100 {
30 err!(
Description
Expressions of the form x == true, !y == false are unnecessary. Consider using the variable directly.
Prefer using the variable directly instead of performing a comparison.
Bad practice
if x == true {}
if y == false {}
Recommended
if x {}
if !y {}