RS-W1065 · Found `todo!` macro

willothy / worth

Active

Found todo! macro RS-W1065

Anti-pattern

Minor

a year ago — a year old

Found todo! macro

681                });
682                tc!(push: Int)
683            }
684            unim => todo!(685                "Implement typechecking for instruction {} at {}",686                unim,687                err_loc(&inst.loc)688            ),689        };
690        if debugger {
691            println!("{}: {:?}", ip, inst);

Found todo! macro

src/error.rs

409                    Value::Str(s) => format!("\"{}\"", s),
410                    v => v.to_string(),
411                },
412                TokenType::Syscall(_) => todo!(),413            };
414
415            fmt_tokens.push(FmtToken {

Found todo! macro

src/main.rs

50            cfg::dump(&program, opt)?;
51        }
52        None => {
53            todo!("Implement repl")54        }
55    };
56

Found todo! macro

src/codegen/compile.rs

 59                Value::Char(c) => {
 60                    asm!(asm, ("push", "{}", c))
 61                }
 62                Value::Ptr(_) => todo!(), 63                Value::Str(s) => {
 64                    let s_id = asm.new_const_str(s);
 65                    asm!(

Found todo! macro

src/sim.rs

181                    });
182                }
183            }
184            Value::Ptr(_name) => todo!(),185        },
186        InstructionKind::Syscall(SyscallKind::Syscall0) => {
187            let syscall = pop!();

Description

The presence of the todo! macro in code indicates an incomplete implementation. Consider revisiting this code.

Bad practice

fn f() -> u32 {
    todo!()
}