Found assignment operators in conditional expressions JS-0001
Bug risk
5 months ago
—
5 months old
Expected a conditional expression and instead saw an assignment
452 ) {
453 if (((c = t), (f = e), 1 === p && (U.test(t) || z.test(t)))) {
454 ((f = (ee.test(t) && ye(e.parentNode)) || e) === e && d.scope) ||
455 ((s = e.getAttribute("id")) 456 ? (s = s.replace(re, ie))
457 : e.setAttribute("id", (s = S))),
458 (o = (l = h(t)).length);Expected a conditional expression and instead saw an assignment
5292 t.head.appendChild(r))
5293 : (t = E)),
5294 (o = !n && []),
5295 (i = N.exec(e)) 5296 ? [t.createElement(i[1])]
5297 : ((i = xe([e], t, o)),
5298 o && o.length && S(o).remove(),Expected a conditional expression and instead saw an assignment
10762 u = X.closest("body");
10763 if (
10764 (l.iframeTarget
10765 ? (n = (d = q(l.iframeTarget, s)).attr2("name"))10766 ? (o = n)
10767 : d.attr2("name", o)
10768 : (d = q(Expected a conditional expression and instead saw an assignment
10952 u = (l.dataType || "").toLowerCase(),
10953 c = /(json|script|text)/.test(u);
10954 c || l.textarea
10955 ? (o = S.getElementsByTagName("textarea")[0])10956 ? ((p.responseText = o.value),
10957 (p.status = Number(o.getAttribute("status")) || p.status),
10958 (p.statusText =Expected a conditional expression and instead saw an assignment
452 ) {
453 if (((c = t), (f = e), 1 === p && (U.test(t) || z.test(t)))) {
454 ((f = (ee.test(t) && ye(e.parentNode)) || e) === e && d.scope) ||
455 ((s = e.getAttribute("id")) 456 ? (s = s.replace(re, ie))
457 : e.setAttribute("id", (s = S))),
458 (o = (l = h(t)).length);
Description
In conditional statements, it is very easy to mistype a comparison operator (such as == or ===) as an assignment operator (such as =).
Bad Practice
// Unintentional assignment
let x;
if (x = 0) {
let b = 1;
}
Recommended
// Assignment replaced by comparison
let x;
if (x === 0) {
let b = 1;
}
let y;
if (y === 0) {
let b = 1;
}