No default cases in switch statements JS-0047
Anti-pattern
Minor
5 months ago
—
2 years old
Expected a default case
10439 return;
10440 }
10441
10442 switch (storage) {10443 case "local":10444 if (hasLocalStorage) {10445 localStorage.setItem("Drupal.webform.message." + id, true);10446 }10447 break;1044810449 case "session":10450 if (hasSessionStorage) {10451 sessionStorage.setItem("Drupal.webform.message." + id, true);10452 }10453 break;1045410455 case "user":10456 case "state":10457 case "custom":10458 $.get($element.find(".js-webform-message__link").attr("href"));10459 return true;10460 }10461 }
10462})(jQuery, Drupal);
10463/*!Expected a default case
10377 var id = $element.attr("data-message-id");
10378 var storage = $element.attr("data-message-storage");
10379 var effect = $element.attr("data-message-close-effect") || "hide";
10380 switch (effect) {10381 case "slide":10382 effect = "slideUp";10383 break;1038410385 case "fade":10386 effect = "fadeOut";10387 break;10388 }10389
10390 // Check storage status.
10391 if (isClosed($element, storage, id)) {Expected a default case
6485 else return !0;
6486 var c = a[1];
6487 if (100 == c) return !0;
6488 switch (a[0]) { 6489 case "v": 6490 return !1; 6491 case "r": 6492 return ( 6493 (c = a[2] % Math.floor(100 / c)), 6494 a[2]++, 6495 this.set(f, a.join(":")), 6496 !c 6497 ); 6498 } 6499 return !0;
6500 };
6501 this.go = function () {Expected a default case
9526 var c = i ? F(i) : null;
9527 if (null != c) {
9528 var p = "y" === c ? "height" : "width";
9529 switch (a) { 9530 case M: 9531 t[c] = t[c] - (n[p] / 2 - r[p] / 2); 9532 break; 9533 case k: 9534 t[c] = t[c] + (n[p] / 2 - r[p] / 2); 9535 } 9536 }
9537 return t;
9538 }Expected a default case
9098 return;
9099 }
9100
9101 switch (storage) { 9102 case "local": 9103 if (hasLocalStorage) { 9104 localStorage.setItem("Drupal.webform.message." + id, true); 9105 } 9106 break; 9107 9108 case "session": 9109 if (hasSessionStorage) { 9110 sessionStorage.setItem("Drupal.webform.message." + id, true); 9111 } 9112 break; 9113 9114 case "user": 9115 case "state": 9116 case "custom": 9117 $.get($element.find(".js-webform-message__link").attr("href")); 9118 return true; 9119 } 9120 }
9121})(jQuery, Drupal);
9122/**
Description
Some code conventions require that all switch statements have a default case, even if the default case is empty. The idea is to always explicitly state what the default behavior should be so that it's clear that the developer didn't forget to handle the default fallback case.
Bad Practice
switch (a) {
case 1:
/* code */
break;
}
Recommended
switch (a) {
case 1:
/* code */
break;
default:
/* code */
break;
}
switch (a) {
case 1:
/* code */
break;
// no default
}
switch (a) {
case 1:
/* code */
break;
// No Default
}