Avoid square-bracket notation when accessing properties JS-0049
Anti-pattern
Minor
5 months ago
—
2 years old
["between"] is better written in dot notation
7875 return false;
7876 }
7877
7878 var between = reference["between"] || reference["!between"]; 7879 var betweenParts = between.split(":");
7880 var greater = betweenParts[0];
7881 var less =["greater_equal"] is better written in dot notation
7868 } else if ("greater_equal" in reference) {
7869 return (
7870 value !== "" &&
7871 parseFloat(reference["greater_equal"]) <= parseFloat(value) 7872 );
7873 } else if ("between" in reference || "!between" in reference) {
7874 if (value === "") {["greater"] is better written in dot notation
7863 );
7864 } else if ("greater" in reference) {
7865 return (
7866 value !== "" && parseFloat(reference["greater"]) < parseFloat(value) 7867 );
7868 } else if ("greater_equal" in reference) {
7869 return (["less_equal"] is better written in dot notation
7859 return value !== "" && parseFloat(reference["less"]) > parseFloat(value);
7860 } else if ("less_equal" in reference) {
7861 return (
7862 value !== "" && parseFloat(reference["less_equal"]) >= parseFloat(value) 7863 );
7864 } else if ("greater" in reference) {
7865 return (["less"] is better written in dot notation
7856 } else if ("!pattern" in reference) {
7857 return !new RegExp(reference["!pattern"]).test(value);
7858 } else if ("less" in reference) {
7859 return value !== "" && parseFloat(reference["less"]) > parseFloat(value); 7860 } else if ("less_equal" in reference) {
7861 return (
7862 value !== "" && parseFloat(reference["less_equal"]) >= parseFloat(value)
Description
In JavaScript, there are two ways to access the properties of an object:
- dot-notation
(object.property)( Recommended ) - square-bracket notation
(object["property"])( Bad Practice )
The dot notation is preferred because it is easier to read, less verbose, and works better with aggressive JavaScript minimizers.
Bad Practice
const x = object["property"];
Recommended
const x = object.property;
x = object[y];