Avoid square-bracket notation when accessing properties JS-0049
Anti-pattern
5 months ago
—
5 months old
["catch"] is better written in dot notation
2076 }
2077 (S.fn.ready = function (e) {
2078 return (
2079 F.then(e)["catch"](function (e) { 2080 S.readyException(e);
2081 }),
2082 this["throws"] is better written in dot notation
4974 break;
4975 }
4976 if (!0 !== a)
4977 if (a && e["throws"]) t = a(t); 4978 else
4979 try {
4980 t = a(t);["pattern"] is better written in dot notation
7841 // @see http://drupalsun.com/julia-evans/2012/03/09/extending-form-api-states-regular-expressions
7842 Drupal.states.Dependent.comparisons.Object = function (reference, value) {
7843 if ("pattern" in reference) {
7844 return new RegExp(reference["pattern"]).test(value); 7845 } else if ("!pattern" in reference) {
7846 return !new RegExp(reference["!pattern"]).test(value);
7847 } else if ("less" in reference) {["less"] is better written in dot notation
7845 } else if ("!pattern" in reference) {
7846 return !new RegExp(reference["!pattern"]).test(value);
7847 } else if ("less" in reference) {
7848 return value !== "" && parseFloat(reference["less"]) > parseFloat(value); 7849 } else if ("less_equal" in reference) {
7850 return (
7851 value !== "" && parseFloat(reference["less_equal"]) >= parseFloat(value)["less_equal"] is better written in dot notation
7848 return value !== "" && parseFloat(reference["less"]) > parseFloat(value);
7849 } else if ("less_equal" in reference) {
7850 return (
7851 value !== "" && parseFloat(reference["less_equal"]) >= parseFloat(value) 7852 );
7853 } else if ("greater" in reference) {
7854 return (
Description
In JavaScript, there are two ways to access the properties of an object:
- dot-notation
(object.property)( Recommended ) - square-bracket notation
(object["property"])( Bad Practice )
The dot notation is preferred because it is easier to read, less verbose, and works better with aggressive JavaScript minimizers.
Bad Practice
const x = object["property"];
Recommended
const x = object.property;
x = object[y];