Null comparisons without type-checking operators may not work as intended JS-0059
Bug risk
5 months ago
—
5 months old
Use '===' to compare with null.
11521 var c = o[l],
11522 r = c.getAttribute("aria-controls"),
11523 s = document.getElementById(r);
11524 if (null == s)11525 throw new Error(
11526 "AU.accordion.Toggle cannot find the target to be toggled from inside aria-controls.\nMake sure the first argument you give AU.accordion.Toggle is the DOM element (a button or a link) that has an aria-controls attribute that points to a div that you want to toggle."
11527 );Use '===' to compare with null.
11183 for (var t = [], r = 0, a = this.length; r < a; r++) {
11184 var n = this[r],
11185 o = q.fieldValue(n, e);
11186 null == o ||11187 (o.constructor === Array && !o.length) ||
11188 (o.constructor === Array ? q.merge(t, o) : t.push(o));
11189 }Use '===' to compare with null.
11173 if (t && t.constructor === Array)
11174 for (var r = 0, a = t.length; r < a; r++)
11175 o.push({ name: e, value: t[r] });
11176 else null != t && o.push({ name: this.name, value: t });11177 }
11178 }),
11179 q.param(o)Use '===' to compare with null.
11138 a.push({ name: m, value: g[i], type: u.type });
11139 else a.push({ name: m, value: "", type: u.type });
11140 } else
11141 null != s &&11142 (t && t.push(u),
11143 a.push({
11144 name: m,Use '===' to compare with null.
9028}
9029
9030function _arrayLikeToArray(arr, len) {
9031 if (len == null || len > arr.length) len = arr.length; 9032 for (var i = 0, arr2 = new Array(len); i < len; i++) {
9033 arr2[i] = arr[i];
9034 }
Description
Comparing to null without a type-checking operator (=== or !==), can have unintended results as the comparison will evaluate to true when comparing to not just a null, but also an undefined value.
Bad Practice
if (flag == null) {
change();
}
while (isSet != null) {
handle();
}
Recommended
if (flag === null) {
change();
}
while (isSet !== null) {
handle();
}