Found redeclared variables JS-0085
Bug risk
5 months ago
—
5 months old
'a' is already defined
6448 var g = function (e, h, f, g) {
6449 this.get = function (a) {
6450 for (
6451 var a = a + "=", c = document.cookie.split(";"), b = 0, e = c.length; 6452 b < e;
6453 b++
6454 ) {'b' is already defined
6459 };
6460 this.set = function (a, c) {
6461 var b = "",
6462 b = new Date(); 6463 b.setTime(b.getTime() + 6048e5);
6464 b = "; expires=" + b.toGMTString();
6465 document.cookie = a + "=" + c + b + "; path=/; ";'alertOverlay' is already defined
6898 "true" == document.getElementById(id).getAttribute("aria-invalid") &&
6899 document.getElementById(id).setAttribute("aria-describedby", id);
6900 }
6901 var alertOverlay = document.getElementById( 6902 "edit-do-you-find-this-page-useful-no"
6903 ),
6904 radioYes = document.getElementById('$checkboxes' is already defined
7937 if (isMultiple) {
7938 // Checkboxes.
7939 var $tbody = $target.find("tbody");
7940 var $checkboxes = $tbody.find('input[type="checkbox"]'); 7941 copyRequireMessage($target, $checkboxes);
7942 if (e.value) {
7943 $checkboxes.on('l' is already defined
11751 l = o || "au-main-nav__content--open";
11752 else
11753 var a = o || "au-main-nav__content--open",
11754 l = t || "au-main-nav__content--closed";11755 !(function (e, n) {
11756 e.classList
11757 ? e.classList.remove(n)
Description
The var keyword is soft-deprecated, and should not be used to redeclare existing variables.
It is possible to re-declare the same variable using the var keyword:
var a = 1;
var a = 10; // valid!
However, this can have unintentional side effects on the code:
var x = 10;
{
var x = 20;
}
console.log(x); // 20
Bad Practice
var db = dbDriver.loadTables()
{
var db = db.get("usersId:1234") // bad practice!
}
Recommended
// always use 'let' or 'const'
const db = dbDriver.loadTables();
{
const users = db.get("userId:1234") // avoid shadowing
}