Assignment found where both sides are exactly the same JS-0088
Anti-pattern
Major
5 months ago
—
2 years old
'r.href' is assigned to itself
4828 r = E.createElement("a");
4829 try {
4830 (r.href = v.url),
4831 (r.href = r.href), 4832 (v.crossDomain =
4833 Mt.protocol + "//" + Mt.host != r.protocol + "//" + r.host);
4834 } catch (e) {'B' is assigned to itself
9826 "static" !== d((B = u(r))).position &&
9827 "absolute" === c &&
9828 ((H = "scrollHeight"), (T = "scrollWidth")),
9829 (B = B), 9830 i === j || ((i === A || i === D) && a === k))
9831 )
9832 (M = E),'r.href' is assigned to itself
4828 r = E.createElement("a");
4829 try {
4830 (r.href = v.url),
4831 (r.href = r.href), 4832 (v.crossDomain =
4833 Mt.protocol + "//" + Mt.host != r.protocol + "//" + r.host);
4834 } catch (e) {'B' is assigned to itself
12698 "static" !== d((B = u(r))).position &&
12699 "absolute" === c &&
12700 ((H = "scrollHeight"), (T = "scrollWidth")),
12701 (B = B),12702 i === j || ((i === A || i === D) && a === k))
12703 )
12704 (M = E),'r.href' is assigned to itself
4828 r = E.createElement("a");
4829 try {
4830 (r.href = v.url),
4831 (r.href = r.href), 4832 (v.crossDomain =
4833 Mt.protocol + "//" + Mt.host != r.protocol + "//" + r.host);
4834 } catch (e) {
Description
Self assignments have no effect, so probably those are an error due to incomplete refactoring. Those indicate that what you should do is still remaining.
foo = foo;
[bar, baz] = [bar, qiz];
Bad Practice
foo = foo;
[a, b] = [a, b];
[a, ...b] = [x, ...b];
({a, b} = {a, x});
Recommended
foo = bar;
[a, b] = [b, a];
// This pattern is warned by the `no-use-before-define` rule.
let foo = foo;
// The default values have an effect.
[foo = 1] = [foo];
// non-self-assignments with properties.
obj.a = obj.b;
obj.a.b = obj.c.b;
obj.a.b = obj.a.c;
obj[a] = obj["a"];
// This ignores if there is a function call.
obj.a().b = obj.a().b;
a().b = a().b;
// Known limitation: this does not support computed properties except single literal or single identifier.
obj[a + b] = obj[a + b];
obj["a" + "b"] = obj["a" + "b"];