Void operators found JS-0098
Anti-pattern
Minor
5 months ago
—
2 years old
Expected 'undefined' and instead saw 'void'
10562 : "string" == typeof M || (!1 === M && 0 < arguments.length)
10563 ? ((M = { url: M, data: e, dataType: t }),
10564 "function" == typeof r && (M.success = r))
10565 : void 0 === M && (M = {}),10566 (O = M.method || M.type || this.attr2("method")),
10567 (n =
10568 (n =Expected 'undefined' and instead saw 'void'
10487 : "object" == typeof module && module.exports
10488 ? (module.exports = function (e, t) {
10489 return (
10490 void 0 === t &&10491 (t =
10492 "undefined" != typeof window
10493 ? require("jquery")Expected 'undefined' and instead saw 'void'
5479 r["offset" + a],
5480 r["client" + a],
5481 ))
5482 : void 0 === n 5483 ? S.css(e, t, i)
5484 : S.style(e, t, n, i);
5485 },Expected 'undefined' and instead saw 'void'
4395 : null == e
4396 ? ""
4397 : e
4398 : void 0; 4399 },
4400 }),
4401 S.extend({Expected 'undefined' and instead saw 'void'
4388 : t
4389 ? (r = S.valHooks[t.type] || S.valHooks[t.nodeName.toLowerCase()]) &&
4390 "get" in r &&
4391 void 0 !== (e = r.get(t, "value")) 4392 ? e
4393 : "string" == typeof (e = t.value)
4394 ? e.replace(yt, "")
Description
A return; statement with nothing after it is redundant, and has no effect on the runtime behavior of a function.
This can be confusing, so it's better to disallow these redundant statements.
Bad Practice
function foo() { return; }
function foo() {
doSomething();
return;
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
}
function foo() {
switch (bar) {
case 1:
doSomething();
default:
doSomethingElse();
return;
}
}
Recommended
function foo() { return 5; }
function foo() {
return doSomething();
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
qux();
}
function foo() {
switch (bar) {
case 1:
doSomething();
return;
default:
doSomethingElse();
}
}
function foo() {
for (const foo of bar) {
return;
}
}