Prefer the usage of regular expression literals over the
RegExp constructor JS-0115
Anti-pattern
Minor
5 months ago
—
2 years old
Use a regular expression literal instead of the 'RegExp' constructor
6716 * @return {boolean} isInternalSpecial
6717 */
6718 Drupal.google_analytics.isInternalSpecial = function (url) {
6719 var isInternalSpecial = new RegExp("(/go/.*)$", "i"); 6720 return isInternalSpecial.test(url);
6721 };
6722Use a regular expression literal instead of the 'RegExp' constructor
6833 * @return {boolean} isInternalSpecial
6834 */
6835 Drupal.google_analytics.isInternalSpecial = function (url) {
6836 var isInternalSpecial = new RegExp("(/go/.*)$", "i"); 6837 return isInternalSpecial.test(url);
6838 };
6839Use a regular expression literal instead of the 'RegExp' constructor
7213 * @return {boolean} isInternalSpecial
7214 */
7215 Drupal.google_analytics.isInternalSpecial = function (url) {
7216 var isInternalSpecial = new RegExp("(/go/.*)$", "i"); 7217 return isInternalSpecial.test(url);
7218 };
7219Use a regular expression literal instead of the 'RegExp' constructor
6716 * @return {boolean} isInternalSpecial
6717 */
6718 Drupal.google_analytics.isInternalSpecial = function (url) {
6719 var isInternalSpecial = new RegExp("(/go/.*)$", "i"); 6720 return isInternalSpecial.test(url);
6721 };
6722Use a regular expression literal instead of the 'RegExp' constructor
6714 * @return {boolean} isInternalSpecial
6715 */
6716 Drupal.google_analytics.isInternalSpecial = function (url) {
6717 var isInternalSpecial = new RegExp("(/go/.*)$", "i"); 6718 return isInternalSpecial.test(url);
6719 };
6720
Description
When a regular expression is known in advance, it is considered a best practice to avoid the string literal notation on top of the regular expression notation, and use regular expression literals instead of the constructor function.
// bad practice:
const number = new RegExp("^\d\.$");
// recommended:
const number_ = /^\d\.$/;
Regex literals are easier to read and do not require a call to the RegExp constructor at runtime.
Bad Practice
new RegExp("abc");
new RegExp("abc", "u");
RegExp("abc");
RegExp("abc", "u");
new RegExp("\d\d\.\d\d\.\d\d\d\d");
RegExp(`^\d\.$`);
new RegExp(String.raw`^\d\.$`);
Recommended
/abc/;
/abc/u;
/\d\d\.\d\d\.\d\d\d\d/;
/^\d\.$/;
// RegExp constructor is allowed for dynamically generated regular expressions
new RegExp(pattern);
RegExp("abc", flags);
new RegExp(prefix + "abc");
RegExp(`${prefix}abc`);
new RegExp(String.raw`^\d\. ${sufix}`);