Should not have unused variables JS-0128
Bug risk
5 months ago
—
5 months old
'varArgs' is defined but never used. Allowed unused args must match /^_/u
5593
5594if (typeof Object.assign !== "function") {
5595 Object.defineProperty(Object, "assign", {
5596 value: function assign(target, varArgs) { 5597 "use strict";
5598
5599 if (target === null || target === undefined) {'a' is defined but never used. Allowed unused args must match /^_/u
6752})(jQuery, Drupal, drupalSettings);
6753!(function (t) {
6754 Drupal.behaviors.govcms8_uikit_starter_BackToTop = {
6755 attach: function (i, a) { 6756 var o = t("body, html"),
6757 e = t(".back-to-top__link", i);
6758 t(window).scroll(function () {'i' is defined but never used. Allowed unused args must match /^_/u
6771})(jQuery),
6772 (function (t) {
6773 Drupal.behaviors.govcms8_uikit_starter_tableResponsive = {
6774 attach: function (i, a) { 6775 var o = t("table");
6776 t(o).wrap("<div class='table-responsive'></div>");
6777 },'a' is defined but never used. Allowed unused args must match /^_/u
6771})(jQuery),
6772 (function (t) {
6773 Drupal.behaviors.govcms8_uikit_starter_tableResponsive = {
6774 attach: function (i, a) { 6775 var o = t("table");
6776 t(o).wrap("<div class='table-responsive'></div>");
6777 },'i' is defined but never used. Allowed unused args must match /^_/u
6836 alertOverlay = $("main.main-content h2"),
6837 toc = "";
6838 if (alertOverlay.length < 3) return;
6839 alertOverlay.each(function (i) { 6840 var heading = $(this).text(),
6841 anchor = heading.replace(/\s+/g, "_").replace(/\W/g, "").toLowerCase();
6842 $(this)
Description
Found variables that are declared but not used anywhere.
Unused variables are most often the result of incomplete refactoring. They can lead to confusing code and minor performance hitches.
NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.
Bad Practice
// Write-only variables are not considered as used.
var y = 10;
y = 5;
// A variable that modifies only itself isn't considered used.
var z = 0;
z = z + 1;
// Unused argument
(function(x) {
return 5;
})();
// Unused recursive functions also raise this issue.
function fact(n) {
if (n < 2) return 1;
return n * fact(n - 1);
}
// When a function definition destructures an array,
// unused entries from the array also cause warnings.
function getY([x, y]) {
return y;
}
Recommended
var x = 10;
alert(x);
((arg1) => {
return arg1;
})();
let myFunc;
myFunc = (n) => {
// this is legal
if (n < 0) myFunc();
};
// this is also considered legal
console.log(declaredLater);
var declaredLater;
// Only the second argument from the descructured array is used.
function getY([, y]) {
return y;
}