Use shorthand property syntax for object literals JS-0240
Anti-pattern
Minor
5 months ago
—
2 years old
Expected method shorthand
952 }))
953 );
954 },
955 ATTR: function (n, r, i) { 956 return function (e) { 957 var t = se.attr(e, n); 958 return null == t 959 ? "!=" === r 960 : !r || 961 ((t += ""), 962 "=" === r 963 ? t === i 964 : "!=" === r 965 ? t !== i 966 : "^=" === r 967 ? i && 0 === t.indexOf(i) 968 : "*=" === r 969 ? i && -1 < t.indexOf(i) 970 : "$=" === r 971 ? i && t.slice(-i.length) === i 972 : "~=" === r 973 ? -1 < 974 (" " + t.replace(B, " ") + " ").indexOf(i) 975 : "|=" === r && 976 (t === i || 977 t.slice(0, i.length + 1) === i + "-")); 978 }; 979 }, 980 CHILD: function (h, e, t, g, v) {
981 var y = "nth" !== h.slice(0, 3),
982 m = "last" !== h.slice(-4),Expected method shorthand
952 }))
953 );
954 },
955 ATTR: function (n, r, i) { 956 return function (e) { 957 var t = se.attr(e, n); 958 return null == t 959 ? "!=" === r 960 : !r || 961 ((t += ""), 962 "=" === r 963 ? t === i 964 : "!=" === r 965 ? t !== i 966 : "^=" === r 967 ? i && 0 === t.indexOf(i) 968 : "*=" === r 969 ? i && -1 < t.indexOf(i) 970 : "$=" === r 971 ? i && t.slice(-i.length) === i 972 : "~=" === r 973 ? -1 < 974 (" " + t.replace(B, " ") + " ").indexOf(i) 975 : "|=" === r && 976 (t === i || 977 t.slice(0, i.length + 1) === i + "-")); 978 }; 979 }, 980 CHILD: function (h, e, t, g, v) {
981 var y = "nth" !== h.slice(0, 3),
982 m = "last" !== h.slice(-4),Expected method shorthand
952 }))
953 );
954 },
955 ATTR: function (n, r, i) { 956 return function (e) { 957 var t = se.attr(e, n); 958 return null == t 959 ? "!=" === r 960 : !r || 961 ((t += ""), 962 "=" === r 963 ? t === i 964 : "!=" === r 965 ? t !== i 966 : "^=" === r 967 ? i && 0 === t.indexOf(i) 968 : "*=" === r 969 ? i && -1 < t.indexOf(i) 970 : "$=" === r 971 ? i && t.slice(-i.length) === i 972 : "~=" === r 973 ? -1 < 974 (" " + t.replace(B, " ") + " ").indexOf(i) 975 : "|=" === r && 976 (t === i || 977 t.slice(0, i.length + 1) === i + "-")); 978 }; 979 }, 980 CHILD: function (h, e, t, g, v) {
981 var y = "nth" !== h.slice(0, 3),
982 m = "last" !== h.slice(-4),Expected method shorthand
952 }))
953 );
954 },
955 ATTR: function (n, r, i) { 956 return function (e) { 957 var t = se.attr(e, n); 958 return null == t 959 ? "!=" === r 960 : !r || 961 ((t += ""), 962 "=" === r 963 ? t === i 964 : "!=" === r 965 ? t !== i 966 : "^=" === r 967 ? i && 0 === t.indexOf(i) 968 : "*=" === r 969 ? i && -1 < t.indexOf(i) 970 : "$=" === r 971 ? i && t.slice(-i.length) === i 972 : "~=" === r 973 ? -1 < 974 (" " + t.replace(B, " ") + " ").indexOf(i) 975 : "|=" === r && 976 (t === i || 977 t.slice(0, i.length + 1) === i + "-")); 978 }; 979 }, 980 CHILD: function (h, e, t, g, v) {
981 var y = "nth" !== h.slice(0, 3),
982 m = "last" !== h.slice(-4),Expected method shorthand
4320 }
4321 return this;
4322 },
4323 toggleClass: function (i, t) { 4324 var o = typeof i, 4325 a = "string" === o || Array.isArray(i); 4326 return "boolean" == typeof t && a 4327 ? t 4328 ? this.addClass(i) 4329 : this.removeClass(i) 4330 : m(i) 4331 ? this.each(function (e) { 4332 S(this).toggleClass(i.call(this, e, gt(this), t), t); 4333 }) 4334 : this.each(function () { 4335 var e, t, n, r; 4336 if (a) { 4337 (t = 0), (n = S(this)), (r = vt(i)); 4338 while ((e = r[t++])) 4339 n.hasClass(e) ? n.removeClass(e) : n.addClass(e); 4340 } else 4341 (void 0 !== i && "boolean" !== o) || 4342 ((e = gt(this)) && Y.set(this, "__className__", e), 4343 this.setAttribute && 4344 this.setAttribute( 4345 "class", 4346 e || !1 === i ? "" : Y.get(this, "__className__") || "", 4347 )); 4348 }); 4349 }, 4350 hasClass: function (e) {
4351 var t,
4352 n,
Description
ECMAScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.
Here are a few common examples using the ES5 syntax:
const x = 1, y = 2, z = 3;
// properties
const foo = {
x: x,
y: y,
z: z,
};
// methods
const foo = {
a: function() {},
b: function() {}
};
The ES6 equivalent syntax is::
// properties
const foo = {x, y, z};
// methods
const bar = {
a() { return 1 },
b() { return 2 }
};
NOTE: The shorthand properties are equivalent to function expressions.
Meaning that they do not bind their own this inside their bodies.
It is still possible to access properties from the object inside a shorthand member function:
const object = {
x: 1,
getX() {
return this.x // valid
}
}
Bad Practice
const foo = {
bar: function () { return 1 }
};
Recommended
const foo = {
bar() { return 1 }
}