Found control characters in regular expression JS-W1035
Bug risk
Minor
5 months ago
—
6 months old
Regular expression contains non-printing character
2472 var ce,
2473 fe,
2474 pe = /^(?:checkbox|radio)$/i,
2475 de = /<([a-z][^\/\0>\x20\t\r\n\f]*)/i, 2476 he = /^$|^module$|\/(?:java|ecma)script/i;
2477 (ce = E.createDocumentFragment().appendChild(E.createElement("div"))),
2478 (fe = E.createElement("input")).setAttribute("type", "radio"),Regular expression contains non-printing character
1782 };
1783 },
1784 );
1785 var P = /[^\x20\t\r\n\f]+/g; 1786 function R(e) {
1787 return e;
1788 }Regular expression contains non-printing character
1579 function A(e, t) {
1580 return e.nodeName && e.nodeName.toLowerCase() === t.toLowerCase();
1581 }
1582 var N = /^<([a-z][^\/\0>:\x20\t\r\n\f]*)[\x20\t\r\n\f]*\/?>(?:<\/\1>|)$/i; 1583 function j(e, n, r) {
1584 return m(n)
1585 ? S.grep(e, function (e, t) {Regular expression contains non-printing character
375 : String.fromCharCode((n >> 10) | 55296, (1023 & n) | 56320))
376 );
377 },
378 re = /([\0-\x1f\x7f]|^-?\d)|^-$|[^\0-\x1f\x7f-\uFFFF\w-]/g, 379 ie = function (e, t) {
380 return t
381 ? "\0" === eRegular expression contains non-printing character
2472 var ce,
2473 fe,
2474 pe = /^(?:checkbox|radio)$/i,
2475 de = /<([a-z][^\/\0>\x20\t\r\n\f]*)/i, 2476 he = /^$|^module$|\/(?:java|ecma)script/i;
2477 (ce = E.createDocumentFragment().appendChild(E.createElement("div"))),
2478 (fe = E.createElement("input")).setAttribute("type", "radio"),
Description
ASCII character codes between 0 and 32 are reserved for non-printing characters. Such characters are unlikely to be present in JavaScript strings, and matching them with a Regular expression is most likely a mistake. Even when you do want to match them, it is recommended to use the character literals for better clarity:
const tabsAndSpaces = / \t/
const tabsSpacesAndNewLines = /\s/
If you find yourself needing to match the hex values for some reason, consider adding a skipcq comment to inform readers about the use-case. This will also prevent DeepSource from raising the issue.
Bad Practice
const rSpaces = /\x1a/;
// A regex like this one is rarely useful:
const regExp = new RegExp("\x12");
Recommended
const rSpaces = / /;
const regExp = new RegExp("[\sa-z]+no-control-chars-here");