Found empty functions JS-0057
Anti-pattern
Minor
5 months ago
—
6 months old
Unexpected empty method 'onUpdate'
1740 eventsEnabled: !0,
1741 removeOnDestroy: !1,
1742 onCreate: function () {},
1743 onUpdate: function () {},1744 modifiers: {
1745 shift: {
1746 order: 100,Unexpected empty method 'onCreate'
1739 positionFixed: !1,
1740 eventsEnabled: !0,
1741 removeOnDestroy: !1,
1742 onCreate: function () {},1743 onUpdate: function () {},
1744 modifiers: {
1745 shift: {Unexpected empty function 'e'
110 h =
111 window.Promise ||
112 function (t) {
113 function e() {} 114 t(e, e);
115 },
116 S = function (t) {
Description
Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.
Bad Practice
getUser('SwaGaLisTiQuE', () => {})
function f() {}
Recommended
getUser('SwaGaLisTiQuE', () => {
// empty because <reason>
})
function f() {
// intentionally empty. <reason>
}