Void operators found JS-0098
Anti-pattern
Minor
5 months ago
—
6 months old
Expected 'undefined' and instead saw 'void'
3889 t < this._offsets[0] &&
3890 this._offsets[0] > 0
3891 )
3892 return (this._activeTarget = null), void this._clear();3893 for (var o = this._offsets.length; o--; ) {
3894 this._activeTarget !== this._targets[o] &&
3895 t >= this._offsets[o] &&Expected 'undefined' and instead saw 'void'
3210 : n._leave(null, n);
3211 } else {
3212 if (i.default(this.getTipElement()).hasClass("show"))
3213 return void this._leave(null, this);3214 this._enter(null, this);
3215 }
3216 }),Expected 'undefined' and instead saw 'void'
2852 !t)
2853 )
2854 return;
2855 if (!n) return void t();2856 var o = l.getTransitionDurationFromElement(this._backdrop);
2857 i.default(this._backdrop)
2858 .one(l.TRANSITION_END, t)Expected 'undefined' and instead saw 'void'
2530 i
2531 .default(n.querySelector('[data-toggle="dropdown"]'))
2532 .trigger("focus"),
2533 void i.default(this).trigger("click")2534 );
2535 var r = [].slice
2536 .call(Expected 'undefined' and instead saw 'void'
2284 }),
2285 (e.show = function (e) {
2286 if (
2287 (void 0 === e && (e = !1),2288 !(
2289 this._element.disabled ||
2290 i.default(this._element).hasClass("disabled") ||
Description
A return; statement with nothing after it is redundant, and has no effect on the runtime behavior of a function.
This can be confusing, so it's better to disallow these redundant statements.
Bad Practice
function foo() { return; }
function foo() {
doSomething();
return;
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
}
function foo() {
switch (bar) {
case 1:
doSomething();
default:
doSomethingElse();
return;
}
}
Recommended
function foo() { return 5; }
function foo() {
return doSomething();
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
qux();
}
function foo() {
switch (bar) {
case 1:
doSomething();
return;
default:
doSomethingElse();
}
}
function foo() {
for (const foo of bar) {
return;
}
}