Method uses the same code for multiple branches JAVA-W0411
Anti-pattern
Minor
a year ago
—
a year old
This branch is duplicated elsewhere in this block
195 // dealer wins
196 } else if(p.getHandAmount(card) > dealer.getHandAmount(card)){
197 // player wins
198 } else if(p.getHandAmount(card) < dealer.getHandAmount(card)){199 // dealer wins200 } else {201 // tie
202 }
203 }
Description
This method seems to have the same code for multiple branch statements.
This could be a valid usage for clarity's sake, but it might also indicate a typo.
Bad Practice
if (someCondition) {
System.out.println("a");
System.out.println(1 + new Random().nextInt());
} else if (someOtherCondition) { // The else if block has the same content as the first if block...
System.out.println("a");
System.out.println(1 + new Random().nextInt());
} else if (new Random().nextBoolean()) {
if ("3".equals("4")) System.out.println(3 + new Random().nextInt());
}
Recommended
If the duplication was intended, consider just combining the conditions with an OR operator:
if (someCondition || someOtherCondition) {
System.out.println("a");
System.out.println(1 + new Random().nextInt());
}
References
- SpotBugs - DBDUPLICATEBRANCHES