Function literal can be simplified CRT-A0018
Anti-pattern
Major
a year ago
—
a year old
replace
func(cnf *config.Control) error {
return testutil.GenerateRuntime(cnf)
} with testutil.GenerateRuntime150 config: generateTestConfig(),
151 handler: generateTestHandler(),
152 },
153 setup: func(cnf *config.Control) error {154 return testutil.GenerateRuntime(cnf)
155 },
156 teardown: func(cnf *config.Control) error {
Description
Function literals that only call a single function, without making any other changes to the value of the inner function, can be removed, as they are redundant. Instead, the inner function, that is being called inside the outer function should be called.
Bad practice
_ = func(x int, y int) int { return add(x, y) }(1, 2)
Recommended
_ = add(1, 2)