Importing the same package multiple times GO-W5021
Anti-pattern
Minor
6 months ago
—
a year old
package "k8s.io/cloud-provider" is being imported more than once
27 "k8s.io/client-go/tools/cache"
28 "k8s.io/client-go/tools/clientcmd"
29 toolswatch "k8s.io/client-go/tools/watch"
30 ccm "k8s.io/cloud-provider" 31 cloudprovider "k8s.io/cloud-provider"
32 cloudproviderapi "k8s.io/cloud-provider/api"
33 ccmapp "k8s.io/cloud-provider/app"package "k8s.io/apimachinery/pkg/api/errors" is being imported more than once
24 controllersv1 "github.com/xiaods/k8e/pkg/generated/controllers/k8e.cattle.io/v1"
25 pkgutil "github.com/xiaods/k8e/pkg/util"
26 corev1 "k8s.io/api/core/v1"
27 "k8s.io/apimachinery/pkg/api/errors" 28 apierrors "k8s.io/apimachinery/pkg/api/errors"
29 metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
30 "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"package "k8s.io/api/core/v1" is being imported more than once
8 "github.com/pkg/errors"
9 "github.com/sirupsen/logrus"
10 "github.com/xiaods/k8e/pkg/version"
11 corev1 "k8s.io/api/core/v1"12 v1 "k8s.io/api/core/v1"
13 cloudprovider "k8s.io/cloud-provider"
14)
Description
Go allows importing the same package multiple times, as long as different import aliases are being used.
However, this is very rarely done on purpose. Usually, it is a sign of code that got refactored, accidentally adding duplicate import statements. It is also a rarely known feature, which may contribute to confusion.
Bad practice
import (
"fmt"
fumpt "fmt"
format "fmt"
_ "fmt"
)
Recommended
import (
"fmt"
)