Functions prefixed with
Get should return a value RVV-A0006
Anti-pattern
Major
8 months ago
—
3 years old
function 'getAPIAddressFromEtcd' seems to be a getter but it does not return any result
540 return value
541}
542
543func getAPIAddressFromEtcd(ctx context.Context, serverConfig server.Config, agentConfig cmds.Agent) {544 defer close(agentConfig.APIAddressCh)
545 for {
546 toCtx, cancel := context.WithTimeout(ctx, 5*time.Second)
Description
Typically, functions with names prefixed with Get are supposed to return a value.
Bad practice
func GetData(n int) {
fmt.Println(10 - n)
}
Recommended
func GetData(n int) int {
fmt.Println(10 - n)
return 10 - n
}