Found
x.Sub(time.Now()) instead of time.Until(x) SCC-S1024
Anti-pattern
Major
a year ago
—
a year old
should use time.Until instead of t.Sub(time.Now())
202 ttl := "<forever>"
203 expires := "<never>"
204 if token.Expires != nil {
205 ttl = duration.ShortHumanDuration(token.Expires.Sub(time.Now()))206 expires = token.Expires.Format(time.RFC3339)
207 }
208
Description
The time.Until helper has the same effect as using x.Sub(time.Now()). The
former is easier to read.
Bad practice
x.Sub(time.Now())
Recommended
time.Until(x)