PYL-W0101 · Statement not reachable on execution

xqt / pwb

Active

Statement not reachable on execution PYL-W0101

Anti-pattern

Critical

4 days ago — 2 years old

Unreachable code

638                        f'Redirect target {targetPage} forms a redirect loop.')
639                    break  # FIXME: doesn't work. edits twice!
640
641                    if self.opt.delete:642                        # Delete the two redirects
643                        # TODO: Check whether pages aren't vandalized
644                        # and (maybe) do not have a version history

Description

This statement is unreachable, as the control flow will never reach upto this point. Consider removing this part of code or re-evaluating the control flow.

Bad practice

def count_pairs(users):
    pairs = 0
    for user in users:
        if user.type == "student":
            pairs += 1
    return pairs
    pairs /= 2  # <-- Unreachable

Preferred

def count_pairs(users):
    pairs = 0
    for user in users:
        if user.type == "student":
            pairs += 1
    pairs /= 2
    return pairs