PYL-W0622 · Re-definition found for builtin function

xqt / pwb

Active

Re-definition found for builtin function PYL-W0622

Anti-pattern

Major

3 days ago — 2 years old

Redefining built-in 'TimeoutError'

  13
  14import pywikibot
  15from pywikibot.data import api
  16from pywikibot.exceptions import (  17    APIError,
  18    Error,
  19    HiddenKeyError,

Redefining built-in 'TimeoutError'

tests/page_tests.py

  16import pywikibot
  17import pywikibot.page
  18from pywikibot import config
  19from pywikibot.exceptions import (  20    Error,
  21    InvalidTitleError,
  22    IsNotRedirectPageError,

Redefining built-in 'TimeoutError'

tests/flow_edit_tests.py

 10import unittest
 11from contextlib import contextmanager, suppress
 12
 13from pywikibot.exceptions import LockedPageError, TimeoutError 14from pywikibot.flow import Board, Post, Topic
 15from tests.aspects import TestCase
 16from tests.utils import skipping

Redefining built-in 'input'

tests/diff_tests.py

265    @patch('pywikibot.info')
266    @patch('pywikibot.userinterfaces.buffer_interface.UI.input',
267           return_value='q')
268    def test_by_letter_quit(self, input, mock):269        """Check cherry_pick output.
270
271        If by_letter diff is enabled and quit during review.

Redefining built-in 'input'

tests/diff_tests.py

252    @patch('pywikibot.info')
253    @patch('pywikibot.userinterfaces.buffer_interface.UI.input',
254           return_value='y')
255    def test_by_letter_accept(self, input, mock):256        """Check cherry_pick output.
257
258        If by_letter diff is enabled and changes accepted.

Description

Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.

Bad practice

dict = {}  # dict is a Python builtin!
for idx, student in enumerate(students):
    dict[student] = idx

Preferred:

roll_number = {}
for idx, student in enumerate(students):
    roll_number[student] = idx