Subprocess run with ignored non-zero exit PYL-W1510
Bug risk
Minor
3 days ago
—
2 years old
'subprocess.run' used without explicitly defining the value for 'check'.
141 self.cleanup()
142
143 info('<<lightyellow>>Check package and description')
144 if run('twine check dist/*', shell=True).returncode:145 return False # pragma: no cover
146
147 if self.local:
Description
subprocess.run uses a default of check=False, which means that a nonzero exit code will be
ignored by default, instead of raising an exception.
You can ignore this issue if this behaviour is intended.
Bad practice
# Nonzero exit code will be ignored here
subprocess.run(['notify-send', '-u', 'critical', msg])
Recommended
# Exception will be raised for nonzero exit code
subprocess.run(['notify-send', '-u', 'critical', msg], check=True) # some comment