Found assignment operators in conditional expressions JS-0001
Bug risk
Major
4 months ago
—
3 years old
Expected a conditional expression and instead saw an assignment
5392 t.head.appendChild(r))
5393 : (t = E)),
5394 (o = !n && []),
5395 (i = D.exec(e)) 5396 ? [t.createElement(i[1])]
5397 : ((i = we([e], t, o)),
5398 o && o.length && k(o).remove(),Expected a conditional expression and instead saw an assignment
9799 $context.find(c.selector).each(function (m, el) {
9800 let instance
9801 const $el = $(el);
9802 (instance = $el.data('component')) 9803 ? _(result).indexOf(instance) == -1 && result.push(instance)
9804 : ((instance = new c.constructor({ el })),
9805 $el.data('component', instance),Expected a conditional expression and instead saw an assignment
443 ) {
444 if (((c = t), (f = e), p === 1 && U.test(t))) {
445 for (
446 (s = e.getAttribute('id')) 447 ? (s = s.replace(re, ie))
448 : e.setAttribute('id', (s = k)),
449 o = (l = h(t)).length;
Description
In conditional statements, it is very easy to mistype a comparison operator (such as == or ===) as an assignment operator (such as =).
Bad Practice
// Unintentional assignment
let x;
if (x = 0) {
let b = 1;
}
Recommended
// Assignment replaced by comparison
let x;
if (x === 0) {
let b = 1;
}
let y;
if (y === 0) {
let b = 1;
}