No default cases in switch statements JS-0047
Anti-pattern
Minor
5 months ago
—
3 years old
Expected a default case
6480 n instanceof h && (n = n._wrapped), r instanceof h && (r = r._wrapped)
6481 const u = p.call(n)
6482 if (u !== p.call(r)) return !1
6483 switch (u) { 6484 case '[object RegExp]': 6485 case '[object String]': 6486 return '' + n == '' + r 6487 case '[object Number]': 6488 return +n != +n ? +r != +r : +n == 0 ? 1 / +n == 1 / r : +n == +r 6489 case '[object Date]': 6490 case '[object Boolean]': 6491 return +n == +r 6492 case '[object Symbol]': 6493 return s.valueOf.call(n) === s.valueOf.call(r) 6494 } 6495 const i = u === '[object Array]'
6496 if (!i) {
6497 if (typeof n !== 'object' || typeof r !== 'object') return !1Expected a default case
5761 ) {
5762 r[t] = arguments[t + i]
5763 }
5764 switch (i) { 5765 case 0: 5766 return u.call(this, r) 5767 case 1: 5768 return u.call(this, arguments[0], r) 5769 case 2: 5770 return u.call(this, arguments[0], arguments[1], r) 5771 } 5772 const e = Array(i + 1)
5773 for (t = 0; t < i; t++) e[t] = arguments[t]
5774 return (e[i] = r), u.apply(this, e)Expected a default case
5717 (h.VERSION = '1.9.2')
5718 function y (u, i, n) {
5719 if (void 0 === i) return u
5720 switch (n == null ? 3 : n) { 5721 case 1: 5722 return function (n) { 5723 return u.call(i, n) 5724 } 5725 case 3: 5726 return function (n, r, t) { 5727 return u.call(i, n, r, t) 5728 } 5729 case 4: 5730 return function (n, r, t, e) { 5731 return u.call(i, n, r, t, e) 5732 } 5733 } 5734 return function () {
5735 return u.apply(i, arguments)
5736 }Expected a default case
5describe('blurt.auth: operation test', () => {
6 it('templates', () => {
7 for (const op in ops) {
8 switch (op) { 9 case 'operation':10 continue11 }12 template(ops[op])
13 }
14 })Expected a default case
250
251 let precision = 0
252 let symbol = ''
253 switch (object.nai) { 254 case '@@000000021': 255 precision = 3 256 symbol = 257 Config.get('address_prefix') == 'BLT' ? 'BLURT' : 'TESTS' 258 break 259 case '@@000000037': 260 precision = 6 261 symbol = 'VESTS' 262 break 263 } 264
265 if (precision > 0) {
266 // Core Symbol Case
Description
Some code conventions require that all switch statements have a default case, even if the default case is empty. The idea is to always explicitly state what the default behavior should be so that it's clear that the developer didn't forget to handle the default fallback case.
Bad Practice
switch (a) {
case 1:
/* code */
break;
}
Recommended
switch (a) {
case 1:
/* code */
break;
default:
/* code */
break;
}
switch (a) {
case 1:
/* code */
break;
// no default
}
switch (a) {
case 1:
/* code */
break;
// No Default
}