Found redeclared variables JS-0085
Bug risk
Minor
4 months ago
—
3 years old
'field' is already defined
117 if (!this.types) return result
118
119 const iterable = this.keys
120 for (var i = 0, field; i < iterable.length; i++) {121 field = iterable[i]
122 const type = this.types[field]
123 const object = type.toObject('field' is already defined
87 var field = null
88 try {
89 const iterable = this.keys
90 for (var i = 0, field; i < iterable.length; i++) { 91 field = iterable[i]
92 const type = this.types[field]
93 const value = serialized_object[field]'field' is already defined
59 var field = null
60 try {
61 const iterable = this.keys
62 for (var i = 0, field; i < iterable.length; i++) { 63 field = iterable[i]
64 const type = this.types[field]
65 type.appendByteBuffer(b, object[field])'field' is already defined
17 var field = null
18 try {
19 const iterable = this.keys
20 for (var i = 0, field; i < iterable.length; i++) { 21 field = iterable[i]
22 const type = this.types[field]
23 try {'typedoc' is already defined
9735var typedoc
9736var typedoc
9737var typedoc
9738var typedoc 9739!(function (typedoc) {
9740 typedoc.$html = $('html')
9741 const services = []
Description
The var keyword is soft-deprecated, and should not be used to redeclare existing variables.
It is possible to re-declare the same variable using the var keyword:
var a = 1;
var a = 10; // valid!
However, this can have unintentional side effects on the code:
var x = 10;
{
var x = 20;
}
console.log(x); // 20
Bad Practice
var db = dbDriver.loadTables()
{
var db = db.get("usersId:1234") // bad practice!
}
Recommended
// always use 'let' or 'const'
const db = dbDriver.loadTables();
{
const users = db.get("userId:1234") // avoid shadowing
}