Assignment found where both sides are exactly the same JS-0088
Anti-pattern
Major
5 months ago
—
3 years old
'r.href' is assigned to itself
4919 r = E.createElement('a')
4920 try {
4921 (r.href = v.url),
4922 (r.href = r.href), 4923 (v.crossDomain =
4924 Ft.protocol + '//' + Ft.host != r.protocol + '//' + r.host)
4925 } catch (e) {
Description
Self assignments have no effect, so probably those are an error due to incomplete refactoring. Those indicate that what you should do is still remaining.
foo = foo;
[bar, baz] = [bar, qiz];
Bad Practice
foo = foo;
[a, b] = [a, b];
[a, ...b] = [x, ...b];
({a, b} = {a, x});
Recommended
foo = bar;
[a, b] = [b, a];
// This pattern is warned by the `no-use-before-define` rule.
let foo = foo;
// The default values have an effect.
[foo = 1] = [foo];
// non-self-assignments with properties.
obj.a = obj.b;
obj.a.b = obj.c.b;
obj.a.b = obj.a.c;
obj[a] = obj["a"];
// This ignores if there is a function call.
obj.a().b = obj.a().b;
a().b = a().b;
// Known limitation: this does not support computed properties except single literal or single identifier.
obj[a + b] = obj[a + b];
obj["a" + "b"] = obj["a" + "b"];