Unused labels found JS-0094
Anti-pattern
Minor
4 months ago
—
3 years old
'any:' is defined but never used
181
182 if (account && account.name) {
183 ["posting", "active", "owner"].forEach((type) => {
184 any: account[type].account_auths.forEach((key: string[]) => {185 if (!validSignature && key[0] === UPLOAD_LIMITS.app_account) {
186 validSignature = true;
187 }
Description
Labels that are declared and not used anywhere in the code are most likely an error due to incomplete refactoring.
OUTER_LOOP:
for (const student of students) {
if (checkScores(student.scores)) {
continue;
}
doSomething(student);
}
In this case, probably removing OUTER_LOOP: had been forgotten. Such labels take up space in the code and can lead to confusion by readers.
Bad Practice
A: var foo = 0;
B: {
foo();
}
C:
for (let i = 0; i < 10; ++i) {
foo();
}
Recommended
A: {
if (foo()) {
break A;
}
bar();
}
B:
for (let i = 0; i < 10; ++i) {
if (foo()) {
break B;
}
bar();
}