unzipper_cb
has a cyclomatic complexity of 168 with "critical" risk 117
118# Callbacks
119@unzipperbot.on_callback_query()
120async def unzipper_cb(unzip_bot: Client, query: CallbackQuery): 121 uid = query.from_user.id
122 if uid != Config.BOT_OWNER: # skipcq: PTC-W0048
123 if await count_ongoing_tasks() >= Config.MAX_CONCURRENT_TASKS:
send_file
has a cyclomatic complexity of 27 with "very-high" risk 46
47
48# Send file to a user
49async def send_file(unzip_bot, c_id, doc_f, query, full_path, log_msg, split): 50 fsize = await get_size(doc_f)
51 if fsize in (-1, 0): # File not found or empty
52 try:
get_audio_metadata
has a cyclomatic complexity of 20 with "high" risk 14from unzipper.modules.ext_script.ext_helper import run_cmds_on_cr, __run_cmds_unzipper
15
16
17async def get_audio_metadata(file_path): 18 file_ext = file_path.split(".")[-1].lower()
19 audio_meta = {"performer": None, "title": None, "duration": None}
20
A function with high cyclomatic complexity can be hard to understand and maintain. Cyclomatic complexity is a software metric that measures the number of independent paths through a function. A higher cyclomatic complexity indicates that the function has more decision points and is more complex.
Functions with high cyclomatic complexity are more likely to have bugs and be harder to test. They may lead to reduced code maintainability and increased development time.
To reduce the cyclomatic complexity of a function, you can:
def number_to_name():
number = input()
if not number.isdigit():
print("Enter a valid number")
return
number = int(number)
if number >= 10:
print("Number is too big")
return
if number == 1:
print("one")
elif number == 2:
print("two")
elif number == 3:
print("three")
elif number == 4:
print("four")
elif number == 5:
print("five")
elif number == 6:
print("six")
elif number == 7:
print("seven")
elif number == 8:
print("eight")
elif number == 9:
print("nine")
def number_to_name():
number = input()
if not number.isdigit():
print("Enter a valid number")
return
number = int(number)
if number >= 10:
print("Number is too big")
return
names = {
1: "one",
2: "two",
3: "three",
4: "four",
5: "five",
6: "six",
7: "seven",
8: "eight",
9: "nine",
}
print(names[number])
Cyclomatic complexity threshold can be configured using the
cyclomatic_complexity_threshold
meta field in the
.deepsource.toml
config file.
Configuring this is optional. If you don't provide a value, the Analyzer will
raise issues for functions with complexity higher than the default threshold,
which is medium
for the Python Analyzer.
Here's the mapping of the risk category to the cyclomatic complexity score to help you configure this better:
Risk category | Cyclomatic complexity range | Recommended action |
---|---|---|
low | 1-5 | No action needed. |
medium | 6-15 | Review and monitor. |
high | 16-25 | Review and refactor. Recommended to add comments if the function is absolutely needed to be kept as it is. |
very-high | 26-50 | Refactor to reduce the complexity. |
critical | >50 | Must refactor this. This can make the code untestable and very difficult to understand. |