Unused parameter in function RVV-B0012
Bug risk
Minor
9 days ago
—
2 years old
parameter 'ctx' seems to be unused, consider removing or renaming it as _
92 return template.HTML(`href="javascript:;"`)
93}
94
95func (file *FileUploadAction) FooterContent(ctx *context.Context) template.HTML {96 return template.HTML(`<input class="` + file.BtnId[1:] + `_input" type="file" multiple="multiple" style="display:none" />`)
97
98}parameter 't' seems to be unused, consider removing or renaming it as _
9 "github.com/stretchr/testify/assert"
10)
11
12func TestKK(t *testing.T) {13 for key := range cn {
14 if _, ok := ptbr[key]; !ok {
15 fmt.Println(key, "===", cn[key])parameter 't' seems to be unused, consider removing or renaming it as _
17 }
18}
19
20func TestAdd(t *testing.T) {21 Add("cn", map[string]string{})
22}
23parameter 'schema' seems to be unused, consider removing or renaming it as _
12 return "sqlite"
13}
14
15func (sqlite) ShowColumnsWithComment(schema, table string) string {16 return "PRAGMA table_info(" + table + ");"
17}
18parameter 'schema' seems to be unused, consider removing or renaming it as _
17 return "postgresql"
18}
19
20func (postgresql) ShowColumnsWithComment(schema, table string) string {21 tableArr := strings.Split(table, "\".\"")
22 if len(tableArr) > 1 {
23 return fmt.Sprintf("select * from information_schema.columns where table_name = '%s' and table_schema = '%s'", tableArr[1], tableArr[0])
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}